Skip to content

feat(store): include group ID in KV events - #19

Merged
stmatengss merged 1 commit into
stmatengss:cursor/kv-event-publisher-master-ca8efrom
kvcache-ai:idhanani/mooncake-2214-event-fixes
Jul 7, 2026
Merged

stmatengss merged 1 commit into
stmatengss:cursor/kv-event-publisher-master-ca8efrom
kvcache-ai:idhanani/mooncake-2214-event-fixes

Conversation

@ishandhanani

@ishandhanani ishandhanani commented Jul 6, 2026 •

Copy link
Copy Markdown

This adds ObjectMetadata.group_id to the physical object events introduced by kvcache-ai#2214. It lets Dynamo collapse repeated rank/K/V membership checks into one verified logical-group lookup without changing Mooncake's event lifecycle.

How This Was Implemented

  • Carry group_id through the publisher's queued event structure.
  • Encode non-empty IDs as group_id and preserve nil for ungrouped objects.
  • Pass the metadata ID through stored and removed event paths, with wire-format coverage.
Walkthrough

Mental model

flowchart LR
    Metadata["ObjectMetadata.group_id"] --> Master["Master event helpers"]
    Master --> Publisher["KV event publisher"]
    Publisher --> Event["MessagePack group_id"]
Loading

State and ordering

The group ID is copied into the pending event when the master emits it, so the asynchronous publisher does not depend on later metadata lifetime. Removal helpers read the ID from the same metadata used to decide global object validity.

Boundaries and limitations

This remains a physical-object event stream: it does not claim that one stored event means the full group is complete. Logical group lifecycle, replay, and snapshot semantics remain follow-up work.

Validation

  • Rebuilt mooncake_master from the current target head.
  • ctest --test-dir build-pr2214-current --output-on-failure -R '^kv_event_publisher_test$' — passed.

Signed-off-by: Ishan Dhanani <ishandhanani@gmail.com>
@coderabbitai

coderabbitai Bot commented Jul 6, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 03a27fa4-112e-4255-ba9a-65f7972e0f24

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ishandhanani
ishandhanani marked this pull request as ready for review July 6, 2026 15:27
@ishandhanani
ishandhanani requested a review from stmatengss as a code owner July 6, 2026 15:27
@stmatengss
stmatengss merged commit 2f9df5b into stmatengss:cursor/kv-event-publisher-master-ca8e Jul 7, 2026
3 checks passed
@zhyncs
zhyncs deleted the idhanani/mooncake-2214-event-fixes branch August 26, 2026 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants