Repository navigation
feat(store): include group ID in KV events - #19
Merged
stmatengss merged 1 commit intoJul 7, 2026
Conversation
Signed-off-by: Ishan Dhanani <ishandhanani@gmail.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 of 21 tasks
ishandhanani
marked this pull request as ready for review
July 6, 2026 15:27
stmatengss
merged commit Jul 7, 2026
2f9df5b
into
stmatengss:cursor/kv-event-publisher-master-ca8e
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
ObjectMetadata.group_idto the physical object events introduced by kvcache-ai#2214. It lets Dynamo collapse repeated rank/K/V membership checks into one verified logical-group lookup without changing Mooncake's event lifecycle.How This Was Implemented
group_idthrough the publisher's queued event structure.group_idand preservenilfor ungrouped objects.Walkthrough
Mental model
flowchart LR Metadata["ObjectMetadata.group_id"] --> Master["Master event helpers"] Master --> Publisher["KV event publisher"] Publisher --> Event["MessagePack group_id"]State and ordering
The group ID is copied into the pending event when the master emits it, so the asynchronous publisher does not depend on later metadata lifetime. Removal helpers read the ID from the same metadata used to decide global object validity.
Boundaries and limitations
This remains a physical-object event stream: it does not claim that one stored event means the full group is complete. Logical group lifecycle, replay, and snapshot semantics remain follow-up work.
Validation
mooncake_masterfrom the current target head.ctest --test-dir build-pr2214-current --output-on-failure -R '^kv_event_publisher_test$'— passed.